[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: more ls changes: stat-failed
From: |
Jim Meyering |
Subject: |
Re: more ls changes: stat-failed |
Date: |
Wed, 26 Jul 2006 10:15:00 +0200 |
Paul Eggert <address@hidden> wrote:
> Jim Meyering <address@hidden> writes:
>
>> ?--------- ? ? ? ? ? cwd
>
> How about outputting something like this instead?
>
> d????????? ? ? ? ? ? cwd
>
> The file type is typically known, so it can be listed as "d" instead
> of "?". Also, this example doesn't show it, but the inode number is
> also known typically, so it shouldn't be listed as "?".
>
> Conversely, the file mode bits are not known, so they should be listed
> as "?" rather than as the (misleading) "-".
>
> I hacked on a patch along these lines but did not have time to finish
> it; it fails the tests due to problems with file name colors. However,
> if you like the idea I can work on cleaning this up.
I do like it. Thanks for doing that.
But please put the name change (s/stat_failed/stat_ok)
in a separate delta.