Re: [PATCH] Implement join --check-order and --nocheck-order.

[Pádraig Brady]

James Youngman wrote:
> This is a consolidated patch including all the previous changes,
> implementing order checking in join by default.  "make distcheck"
> works (if I move distcheck-hook from Makefile.am to GNUmakefile).

While I like the idea, I'm a little worried about the implementation.
You seem to duplicate the buffers rather than the pointers.
Do you really need to do the extra malloc() + memcpy() per line read?

Could you compare the performance of before and after (with LANG=C).

thanks,
Pádraig.