bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] tests: Avoid skipping stty-* tests.


From: Nix
Subject: [PATCH] tests: Avoid skipping stty-* tests.
Date: Tue, 10 Feb 2009 08:04:23 +0000
User-agent: Gnus/5.1008 (Gnus v5.10.8) XEmacs/21.5-b28 (linux)

tests/test-lib.sh (require_controlling_input_terminal_): Check stdout,
not stdin.
---
This testsuite bug causes the stty tests to be skipped, always, because
it's testing stdout, not stdin, and the testsuite engine redirects stdout
to a logfile. They still pass, despite not being run for lo these many
years.

Patch against HEAD. (I'm pretty certain it doesn't require a copyright
assignment. ;) )

 tests/test-lib.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tests/test-lib.sh b/tests/test-lib.sh
index 8bb88d9..0c04af8 100644
--- a/tests/test-lib.sh
+++ b/tests/test-lib.sh
@@ -68,7 +68,7 @@ require_strace_()
 require_controlling_input_terminal_()
 {
   tty -s || have_input_tty=no
-  test -t 1 || have_input_tty=no
+  test -t 0 || have_input_tty=no
   if test "$have_input_tty" = no; then
     echo "$0: This test must have a controlling input \`terminal'," 1>&2
     echo "  so it may not be run via \`batch', \`at', or \`rsh'." 1>&2
-- 
1.6.1.2.41.g8f76f




reply via email to

[Prev in Thread] Current Thread [Next in Thread]