[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Display problem on Windows with time zones containing Non-ASCII char
From: |
Jason Rumney |
Subject: |
Re: Display problem on Windows with time zones containing Non-ASCII characters. |
Date: |
Wed, 06 Jun 2007 00:32:53 +0100 |
User-agent: |
Thunderbird 2.0.0.0 (Windows/20070326) |
Michael Schierl wrote:
> Please describe exactly what actions triggered the bug
> and the precise symptoms of the bug:
>
> - Load emacs -Q on Windows, on German Windows XP
> - M-x calendar
> - Go to 21 June 2007, and press "h"
> - you will see in minibuffer:
>
> Thursday, June 21, 2007: Summer Solstice 8:05pm (Westeurop\344ische
> Normalzeit)
>
>
In current-time-zone (editfns.c), we have the following code:
#if defined HAVE_TM_ZONE || defined HAVE_TZNAME
if (s)
{
/* On Japanese w32, we can get a Japanese string as time
zone name. Don't accept that. */
char *p;
for (p = s; *p && (isalnum ((unsigned char)*p) || *p == ' '); ++p)
;
if (p == s || *p)
s = NULL;
}
#endif
[...]
return Fcons (make_number (offset), Fcons (build_string (s), Qnil));
So the same bug must have been reported in the past for the Japanese
locale on W32, but we covered it over by rejecting non alphanumeric
timezone names rather than fixing the bug by decoding them using
locale_coding_system. I guess w32 is the only system where localized
full timezone names are returned by the tzname call or tm_zone struct
member, which is why we only notice it there.