bug#14308: 24.3.50; Better error messages for `timer-event-handler'

[Michael Heerdegen]

Hi,

since some time, `timer-event-handler' messages error messages in case
of errors (when debug-on-error is nil).  This is good!

However, in my experience these messages as such are currently not very
helpful.  E.g I get a message like

|  Error running timer: (error "Selecting deleted buffer")

Mmh.

I can try setting `debug-on-error' to t (which is a pain in the
ass as long as `user-error' is not very widespread, btw) and hope that
it "happens again".  But it would be better if the message would be more
informative.  E.g. we would win a lot with doing this:

*** /home/micha/today/timer.el  2013-04-29 19:14:33.352241368 +0200
--- /home/micha/today/timer-new.el      2013-04-29 19:15:17.727761145 +0200
***************
*** 313,319 ****
                ;; and it can be hellish to track down their source.
                (save-current-buffer
                  (apply (timer--function timer) (timer--args timer)))
!           (error (message "Error in timer: %S" err)))
          (when (and retrigger (memq timer timer-list)) ;; Stefans fix
              (setf (timer--triggered timer) nil)))
        (error "Bogus timer event"))))
--- 313,319 ----
                ;; and it can be hellish to track down their source.
                (save-current-buffer
                  (apply (timer--function timer) (timer--args timer)))
!           (error (message "Error in timer function %s: %S" (timer--function 
timer) err)))
          (when (and retrigger (memq timer timer-list)) ;; Stefans fix
              (setf (timer--triggered timer) nil)))
        (error "Bogus timer event"))))

It would at least reveal where I have to dig.  Better ideas appreciated!


Regards,

Michael.



In GNU Emacs 24.3.50.1 (x86_64-pc-linux-gnu, GTK+ Version 3.4.2)
 of 2013-04-27 on dex, modified by Debian
 (emacs-snapshot package, version 2:20130427-1)
Windowing system distributor `The X.Org Foundation', version 11.0.11204000
System Description:     Debian GNU/Linux 7.0 (wheezy)