|
From: | Dmitry Gutov |
Subject: | bug#22241: 25.0.50; etags Ruby parser problems |
Date: | Thu, 4 Feb 2016 02:21:53 +0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:44.0) Gecko/20100101 Thunderbird/44.0 |
On 02/03/2016 07:26 PM, Eli Zaretskii wrote:
I implemented that now.
Thanks! One nitpick: attr_WHATEVER :foo, barwill generate the methods for 'foo', and whatever the value of bar is. But bar is not very likely to have the value :bar, so we should only generate the tags for 'foo'.
IOW, skip the arguments that are not Ruby Symbols (don't start with a colon). The current implementation treats them the same.
The test example looks a bit odd as well, but I'll comment on that in a separate email.
[Prev in Thread] | Current Thread | [Next in Thread] |