[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#24409: 25.1.1; dired-jump: Interactive call w/ prefix arg move to wr
From: |
Eli Zaretskii |
Subject: |
bug#24409: 25.1.1; dired-jump: Interactive call w/ prefix arg move to wrong file line |
Date: |
Sun, 11 Sep 2016 20:16:51 +0300 |
> From: Tino Calancha <tino.calancha@gmail.com>
> Date: Mon, 12 Sep 2016 02:03:14 +0900 (JST)
> cc: Tino Calancha <tino.calancha@gmail.com>, 24409@debbugs.gnu.org
>
> *) Please, take a look in the new patch below with more verbose log
> message/comments.
Thanks, see a follow-up comment below.
> *) Where should go the fix: emacs-25 branch or master?
Master, of course.
> - (let* ((file (or file-name buffer-file-name))
> + ;; Expand file-name before calling `dired-goto-file':
> + ;; This is required in interactive calls because the return value
> + ;; of `read-file-name' is not expanded; it also helps in
> + ;; non-interactive calls, where file-name could be an abbreviated
> + ;; file name as ~/dir/file (Bug#24409).
> + (let* ((file (or (and file-name (expand-file-name file-name))
> + buffer-file-name))
I think a better comment would be to say that dired-goto-file requires
its argument to be an absolute file name, and the result of
read-file-name could be an abbreviated file name.
- bug#24409: 25.1.1; dired-jump: Interactive call w/ prefix arg move to wrong file line, Tino Calancha, 2016/09/11
- bug#24409: 25.1.1; dired-jump: Interactive call w/ prefix arg move to wrong file line, Noam Postavsky, 2016/09/11
- bug#24409: 25.1.1; dired-jump: Interactive call w/ prefix arg move to wrong file line, Eli Zaretskii, 2016/09/11
- bug#24409: 25.1.1; dired-jump: Interactive call w/ prefix arg move to wrong file line, Tino Calancha, 2016/09/11
- bug#24409: 25.1.1; dired-jump: Interactive call w/ prefix arg move to wrong file line,
Eli Zaretskii <=
- bug#24409: 25.1.1; dired-jump: Interactive call w/ prefix arg move to wrong file line, Tino Calancha, 2016/09/12
- bug#24409: 25.1.1; dired-jump: Interactive call w/ prefix arg move to wrong file line, Eli Zaretskii, 2016/09/12
- bug#24409: 25.1.1; dired-jump: Interactive call w/ prefix arg move to wrong file line, Tino Calancha, 2016/09/13
- bug#24409: 25.1.1; dired-jump: Interactive call w/ prefix arg move to wrong file line, Eli Zaretskii, 2016/09/13
- bug#24409: 25.1.1; dired-jump: Interactive call w/ prefix arg move to wrong file line, Tino Calancha, 2016/09/13