[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#24456: 25.1; [PATCH] Caps-lock doesn't affect interpretation of key
From: |
Eli Zaretskii |
Subject: |
bug#24456: 25.1; [PATCH] Caps-lock doesn't affect interpretation of key chords |
Date: |
Sun, 18 Sep 2016 17:41:50 +0300 |
> From: Dima Kogan <dima@secretsauce.net>
> Date: Sun, 18 Sep 2016 00:01:23 -0700
>
> diff --git a/src/keyboard.c b/src/keyboard.c
> index b8bc361..a977de5 100644
> --- a/src/keyboard.c
> +++ b/src/keyboard.c
> @@ -5415,6 +5415,32 @@ make_lispy_event (struct input_event *event)
> EMACS_INT c = event->code;
> if (event->kind == ASCII_KEYSTROKE_EVENT)
> {
> + /* Caps-lock shouldn't affect interpretation of key chords:
> + Control+s should produce C-s whether caps-lock is on or
> + not. And Control+Shift+s should produce C-S-s whether
> + caps-lock is on or not. */
> + if (event->modifiers & ~shift_modifier)
> + {
> + /* this is a key chord: some non-shift modifier is
> + depressed */
> +
> + if ('A' <= c && c <= 'Z' &&
> + !(event->modifiers & shift_modifier) )
> + {
> + /* Got a capital letter without a shift. The caps
> + lock is on. Un-capitalize the letter */
> + c |= (unsigned)('a' - 'A');
> + }
> + else if (('a' <= c && c <= 'z') &&
> + (event->modifiers & shift_modifier) )
> + {
> + /* Got a lower-case letter even though shift is
> + depressed. The caps lock is on. Capitalize the
> + letter */
> + c &= ~(unsigned)('a' - 'A');
> + }
> + }
> +
Doesn't this mean that ASCII keys will behave differently from
non-ASCII when Caps Lock is ON?
- bug#24456: 25.1; [PATCH] Caps-lock doesn't affect interpretation of key chords, (continued)
- bug#24456: 25.1; [PATCH] Caps-lock doesn't affect interpretation of key chords, Eli Zaretskii, 2016/09/18
- bug#24456: 25.1; [PATCH] Caps-lock doesn't affect interpretation of key chords, Dima Kogan, 2016/09/19
- bug#24456: 25.1; [PATCH] Caps-lock doesn't affect interpretation of key chords, Eli Zaretskii, 2016/09/19
- bug#24456: 25.1; [PATCH] Caps-lock doesn't affect interpretation of key chords, Dima Kogan, 2016/09/19
- bug#24456: 25.1; [PATCH] Caps-lock doesn't affect interpretation of key chords, Eli Zaretskii, 2016/09/19
- bug#24456: 25.1; [PATCH] Caps-lock doesn't affect interpretation of key chords, Dima Kogan, 2016/09/19
- bug#24456: 25.1; [PATCH] Caps-lock doesn't affect interpretation of key chords, Eli Zaretskii, 2016/09/21
- bug#24456: 25.1; [PATCH] Caps-lock doesn't affect interpretation of key chords, Dima Kogan, 2016/09/21
- bug#24456: 25.1; [PATCH] Caps-lock doesn't affect interpretation of key chords, Eli Zaretskii, 2016/09/22
- bug#24456: 25.1; [PATCH] Caps-lock doesn't affect interpretation of key chords, Dima Kogan, 2016/09/25
bug#24456: 25.1; [PATCH] Caps-lock doesn't affect interpretation of key chords,
Eli Zaretskii <=