[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#24914: 24.5; isearch-regexp: wrong error message
From: |
Noam Postavsky |
Subject: |
bug#24914: 24.5; isearch-regexp: wrong error message |
Date: |
Sun, 03 Dec 2017 13:13:54 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) |
Drew Adams <drew.adams@oracle.com> writes:
>> > 3. C-M-s \(.\|^J\)\{,40000\}
>> > That shows the error message: [incomplete input],
>> > which is wrong, IMO.
>>
>> The reason it doesn't work is because the number of repitions
>> is limited to 32767 (#x7fff).
>
> Yet another case for adding bignums to Emacs Lisp?
> I imagine someone will answer that there needs to be
> a limit.
>
> In that case, can we not use something larger?
> Could we use the value of `most-positive-fixnum'?
It's not a limit in Lisp, but in regex.c.
>> As to the error message itself, there isn't really a way
>> to distinguish between incomplete and invalid input,
>
> We do that in some places in the code.
What places are those?
> Some code parses the regexp, and that code must know (or be able to
> know) both that the regexp is not incomplete
What does it mean for a regexp to be incomplete or not? As far as I can
tell, the only distinction is that the user means to type more; but the
code doesn't know what will happen in the future...
> and that the numeral
> given for the number of repetitions is too large.
I suppose we could change regex.c to give a different error message for
a repetition number that is too high, and then isearch.el could check
for that specially.
- bug#24914: 24.5; isearch-regexp: wrong error message, Noam Postavsky, 2017/12/03
- bug#24914: 24.5; isearch-regexp: wrong error message, Drew Adams, 2017/12/03
- bug#24914: 24.5; isearch-regexp: wrong error message,
Noam Postavsky <=
- bug#24914: 24.5; isearch-regexp: wrong error message, Drew Adams, 2017/12/03
- bug#24914: 24.5; isearch-regexp: wrong error message, Noam Postavsky, 2017/12/04
- bug#24914: 24.5; isearch-regexp: wrong error message, Drew Adams, 2017/12/04
- bug#24914: 24.5; isearch-regexp: wrong error message, Noam Postavsky, 2017/12/04
- bug#24914: 24.5; isearch-regexp: wrong error message, Drew Adams, 2017/12/04
- bug#24914: 24.5; isearch-regexp: wrong error message, Noam Postavsky, 2017/12/04
- bug#24914: 24.5; isearch-regexp: wrong error message, Drew Adams, 2017/12/04
- bug#24914: 24.5; isearch-regexp: wrong error message, Noam Postavsky, 2017/12/05
- bug#24914: 24.5; isearch-regexp: wrong error message, Drew Adams, 2017/12/05
- bug#24914: 24.5; isearch-regexp: wrong error message, Noam Postavsky, 2017/12/05