|
From: | Jaesup Kwak |
Subject: | bug#29565: [PATCH] Support xwidget webkit for macOS X |
Date: | Tue, 5 Dec 2017 15:01:45 +0900 |
In configure.ac you’re doing
elif test "$window_system" = "nextstep"; then
I think instead of that you should be doing
elif test "${NS_IMPL_COCOA}" = "yes"; then
as nextstep covers GNUstep, but it doesn’t have a webkit
implementation (yet).
There might be other places where NS_IMPL_COCOA is more appropriate
than HAVE_NS, but it builds fine against GNUstep with xwidgets off, so
it’s not too important.
I notice you’re adding .DS_Store to .gitignore, which is a good idea,
but I don’t think it should be done in this patch. It seems a little
off‐topic.
I’m also a little unsure about this
<!-- FIXME: Uncomment for xwidget webkit to browse remote url,
but this set no restriction at all. Consult apple's documentation
for detail information about `NSApplicationDefinedMask'. -->
<key>NSAppTransportSecurity</key>
<dict>
<key>NSAllowsArbitraryLoads</key>
<true/>
</dict>
The comment says ‘uncomment’, but it *is* uncommented. Am I
misunderstanding?
(Also I think there should be two spaces at the end of comments.)
I think we’ll want to add NSTRACE lines in each function, but perhaps
we should create a new category for XWidgets.
[Prev in Thread] | Current Thread | [Next in Thread] |