[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#28691: [PATCH] Add file name handler support for 'make-process' (Bug
From: |
Philipp Stephani |
Subject: |
bug#28691: [PATCH] Add file name handler support for 'make-process' (Bug#28691) |
Date: |
Sat, 22 Dec 2018 23:26:11 +0100 |
Am Sa., 22. Dez. 2018 um 10:09 Uhr schrieb Eli Zaretskii <eliz@gnu.org>:
>
> > From: Philipp Stephani <p.stephani2@gmail.com>
> > Cc: 28691@debbugs.gnu.org,
> > Philipp Stephani <phst@google.com>
> > Date: Mon, 17 Dec 2018 21:47:46 +0100
> >
> > * src/process.c (Fmake_process): Add new keyword argument
> > ':file-handler'.
> > (syms_of_process) <make-process, :file-handler>: Define new symbols.
> >
> > * lisp/files.el (file-name-non-special): Add support for
> > 'make-process'.
> >
> > * test/src/process-tests.el (make-process/file-handler/found)
> > (make-process/file-handler/not-found)
> > (make-process/file-handler/disable): New unit tests.
> > (process-tests--file-handler): New helper function.
> >
> > * test/lisp/files-tests.el
> > (files-tests-file-name-non-special-make-process): New unit test.
> >
> > * doc/lispref/files.texi (Magic File Names): Document that
> > 'make-process' can invoke file name handlers.
> >
> > * doc/lispref/processes.texi (Asynchronous Processes): Document
> > ':file-handlers' argument to 'make-process'.
>
> Thanks, this LGTM, but some of the tests use the Emacs binary, while
> others still use /bin/true for some reason. What am I missing?
The one that uses /bin/true never invokes it, but only tests whether
the full argument list is passed to the handler. I've changed this now
to /some/binary to clarify that the actual string doesn't matter.
>
> Please also include etc/NEWS change in the log message.
>
Done and pushed as 039be4e025. Thanks!
- bug#28691: [PATCH] Add file name handler support for 'make-process' (Bug#28691), (continued)
- bug#28691: [PATCH] Add file name handler support for 'make-process' (Bug#28691), Philipp Stephani, 2018/12/17
- bug#28691: [PATCH] Add file name handler support for 'make-process' (Bug#28691), Eli Zaretskii, 2018/12/22
- bug#28691: [PATCH] Add file name handler support for 'make-process' (Bug#28691), Michael Albinus, 2018/12/22
- bug#28691: [PATCH] Add file name handler support for 'make-process' (Bug#28691), Philipp Stephani, 2018/12/22
- bug#28691: [PATCH] Add file name handler support for 'make-process' (Bug#28691), Michael Albinus, 2018/12/23
- bug#28691: [PATCH] Add file name handler support for 'make-process' (Bug#28691), Philipp Stephani, 2018/12/23
- bug#28691: [PATCH] Add file name handler support for 'make-process' (Bug#28691), Michael Albinus, 2018/12/23
- bug#28691: [PATCH] Add file name handler support for 'make-process' (Bug#28691), Eli Zaretskii, 2018/12/23
- bug#28691: [PATCH] Add file name handler support for 'make-process' (Bug#28691), Michael Albinus, 2018/12/23
- bug#28691: [PATCH] Add file name handler support for 'make-process' (Bug#28691), Eli Zaretskii, 2018/12/23
- bug#28691: [PATCH] Add file name handler support for 'make-process' (Bug#28691),
Philipp Stephani <=
- bug#28691: [PATCH] Add file name handler support for 'make-process' (Bug#28691), Michael Albinus, 2018/12/17
- bug#28691: [PATCH] Add file name handler support for 'make-process' (Bug#28691), Drew Adams, 2018/12/17