[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#139: describe-key vs. widget red tape
From: |
Lars Ingebrigtsen |
Subject: |
bug#139: describe-key vs. widget red tape |
Date: |
Mon, 07 Oct 2019 03:55:11 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
"Basil L. Contovounesios" <contovob@tcd.ie> writes:
>> Find in the attached patch my idea to implement this.
>
> Thank you for working on this!
Yes, it looks really useful.
>> There are some things I would like to ask:
>> - I would like to put an initial value of nil to
>> `describe-actions-functions', and let each library add the function to
>> this list. Is it OK to use `with-eval-after-load' here?
>
> I think it's best to avoid it, especially in preloaded libraries like
> button.el.
Yes, I think you can just have the libraries push stuff directly to this
variable (and the variable would define be in a library that's preloaded
in Emacs).
>> - I put an autoload cookie in `seq-find', in order to use it in
>> `describe-actions'. Is it OK?
>
> I think so, but you could also (require 'seq) where it's needed or use
> the already loaded cl-lib library instead.
Putting an autoload cookie there is fine, I think.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no