[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#37641: major/minor tick faces bleed into empty lines at the end of b
From: |
Eli Zaretskii |
Subject: |
bug#37641: major/minor tick faces bleed into empty lines at the end of buffer |
Date: |
Wed, 09 Oct 2019 13:22:47 +0300 |
> From: Juanma Barranquero <lekktu@gmail.com>
> Date: Tue, 8 Oct 2019 12:47:22 +0200
> Cc: 37641@debbugs.gnu.org
>
> Turns out there's a difference after all. See the attached images. If you
> move the
> cursor past the EOB, with the beyond_zv check the line is drawn with the
> line-number
> face, not the line-number-current-line face. If we check with it->what !=
> IT_EOB,
> then the line-number-current-line face is used.
>
> I think the right thing to do, when dealing with the "phantom line" just past
> the EOB,
> is to:
> - Use line-number-current-line, if the cursor is there.
> - Use the line-number face, and not the tick faces, if the cursor is not,
> regardless
> of whether this phantom line would be a tick line or not if it were used.
Agreed.
> So there's a patch that checks for tick faces with beyond_zv, for the current
> line
> face with it->what, and that moves all face setting for line numbers entirely
> out of
> the loop.
LGTM, thanks.
- bug#37641: major/minor tick faces bleed into empty lines at the end of buffer, Juanma Barranquero, 2019/10/06
- bug#37641: major/minor tick faces bleed into empty lines at the end of buffer, Juanma Barranquero, 2019/10/06
- bug#37641: major/minor tick faces bleed into empty lines at the end of buffer, Eli Zaretskii, 2019/10/07
- bug#37641: major/minor tick faces bleed into empty lines at the end of buffer, Eli Zaretskii, 2019/10/08
- bug#37641: major/minor tick faces bleed into empty lines at the end of buffer, Juanma Barranquero, 2019/10/08
- bug#37641: major/minor tick faces bleed into empty lines at the end of buffer, Juanma Barranquero, 2019/10/08
- bug#37641: major/minor tick faces bleed into empty lines at the end of buffer,
Eli Zaretskii <=
- bug#37641: major/minor tick faces bleed into empty lines at the end of buffer, Juanma Barranquero, 2019/10/09