[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#37774: 27.0.50; new :extend attribute broke visuals of all themes an
From: |
Kévin Le Gouguec |
Subject: |
bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages |
Date: |
Thu, 24 Oct 2019 19:04:31 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Dmitry Gutov <dgutov@yandex.ru> writes:
> Yeah, so: what's the plan for Magit?
>
> Will the new version of it have to
>
> (if <emacs version is...>
> (defface ...)
> (defface ...)
>
> ?
> We should define and document a "migration path", e.g. say what a
> package author should do if they have a face which needs to be
> extended, preferably without breaking compatibility with Emacs 26.
Earlier in the thread[1] I suggested this method to avoid the duplicate
defface issue:
--- magit-diff.el.bkp 2019-10-23 17:02:13.340410735 +0200
+++ magit-diff.el 2019-10-24 17:54:58.769446997 +0200
@@ -509,12 +509,14 @@
:group 'magit-faces)
(defface magit-diff-hunk-heading
- '((((class color) (background light))
+ `((((class color) (background light))
:background "grey80"
- :foreground "grey30")
+ :foreground "grey30"
+ ,@(when (>= emacs-major-version 27) '(:extend t)))
(((class color) (background dark))
:background "grey25"
- :foreground "grey70"))
+ :foreground "grey70"
+ ,@(when (>= emacs-major-version 27) '(:extend t))))
"Face for diff hunk headings."
:group 'magit-faces)
Would this be an acceptable migration path? Magit requires Emacs≥25.1
if I am not mistaken; I don't know how portable this solution would be.
[1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=37774#212
AFAICT no-one outright rejected this idea; I apologize if I missed
someone pointing out shortcomings.
- bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages, (continued)
- bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages, Eli Zaretskii, 2019/10/17
- bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages, Dmitry Gutov, 2019/10/18
- bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages, Dmitry Gutov, 2019/10/20
- bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages, Eli Zaretskii, 2019/10/21
- bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages, Dmitry Gutov, 2019/10/23
- bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages, Eli Zaretskii, 2019/10/23
- bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages, Dmitry Gutov, 2019/10/23
- bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages, Eli Zaretskii, 2019/10/23
- bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages, Dmitry Gutov, 2019/10/23
- bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages, Eli Zaretskii, 2019/10/24
- bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages,
Kévin Le Gouguec <=
- bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages, Juri Linkov, 2019/10/17
- bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages, Andrey Orst, 2019/10/18
- bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages, Eli Zaretskii, 2019/10/18
- bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages, Juri Linkov, 2019/10/19
- bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages, Eli Zaretskii, 2019/10/20
- bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages, Juri Linkov, 2019/10/20
- bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages, Eli Zaretskii, 2019/10/20
- bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages, Juri Linkov, 2019/10/21
- bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages, martin rudalics, 2019/10/18
- bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages, Dmitry Gutov, 2019/10/18