bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#46534: Lexical change in bindat breaks weechat.el


From: Kim Storm
Subject: bug#46534: Lexical change in bindat breaks weechat.el
Date: Wed, 17 Feb 2021 23:47:21 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1

On 15/02/2021 16.50, Stefan Monnier wrote:
[ Hi Kim, long time no see.
   I'd appreciate your opinion on this issue with bindat.el.  ]

Hi Stefan

Indeed, it's been a while since I wrote that code :-)

Your change seems to be the simplest way to solve the "not last field" issue with "eval".

BTW, the following line seems wrong:

;;    (length       u16r)  ;; little endian order

Since the C struct specifies "unsigned long", it should be u32r rather than u16r.

Also the C code samples should use uint8_t uint16_t and uint32_t for clarity.

Kim










reply via email to

[Prev in Thread] Current Thread [Next in Thread]