bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#43725: 28.0.50; Include feature/native-comp into master


From: Andrea Corallo
Subject: bug#43725: 28.0.50; Include feature/native-comp into master
Date: Fri, 19 Feb 2021 14:16:56 +0000
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Pip Cet <pipcet@gmail.com>
>> Date: Fri, 19 Feb 2021 12:53:43 +0000
>> Cc: 43725@debbugs.gnu.org, eliz@gnu.org, larsi@gnus.org, 
>>      Stefan Monnier <monnier@iro.umontreal.ca>
>> 
>> > comp.c:1174:22: warning: logical ‘or’ of collectively exhaustive tests is 
>> > always true [-Wlogical-op]
>> >  1174 |   if (val > LONG_MAX || val < LONG_MIN)
>> >       |                      ^~
>> >
>> > Not sure what's the best way to silence it or if we want to revert to
>> > the previous formulation.
>> 
>> Maybe it's me, but I had a hard time parsing that warning. IIUC, the
>> tests are both trivially false? And oring two trivially false
>> conditions shouldn't trigger a warning, should it?
>
> No, I think it tries to say that val is always either greater than
> LONG_MAX or smaller than LONG_MIN.

Exactly, the warning is about the fact that all the other conditions
will never be evaluated.  The phrasing is admittedly quite cryptic tho.

  Andrea





reply via email to

[Prev in Thread] Current Thread [Next in Thread]