[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#43566: 27.1; url-http and excorporate does not authenticate
From: |
Thomas Fitzsimmons |
Subject: |
bug#43566: 27.1; url-http and excorporate does not authenticate |
Date: |
Fri, 19 Feb 2021 17:26:28 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (gnu/linux) |
Thomas Fitzsimmons <fitzsim@fitzsim.org> writes:
> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> Thomas Fitzsimmons <fitzsim@fitzsim.org> writes:
>>
>>> The tests will fail if web-server.el is present but out-of-date, which I
>>> think is unavoidable. But...
>>
>> Would it be possible to check the web-server.el version to make this
>> more robust?
>
> Michael also asked about this on emacs-devel. I looked but I can't see
> a simple way to do it. package.el functionality isn't available in this
> context.
Michael wanted a general approach to requiring specific GNU ELPA package
versions; he suggested an implementation which I adapted and pushed to
master. You can try it by alternating between revisions
a1c767fe56acfed6627682fadc337203f3b8678c and
4edcba28826869b07f622fd83f6aab96fd8e4d19 of web-server.el and confirming
that for the former commit the tests are skipped and for the latter,
they're run.
I also tested how url-retrieve-synchronously behaves with NTLM
authentication when the authinfo password is wrong. It doesn't
infinite-loop -- it tries once with the authinfo credentials and if they
fail, it prompts the user for a username and password. Therefore, the
patch that caused the regression isn't needed for NTLM and the
workaround patch I pushed is fine as-is.
I'm marking this bug done.
Thanks,
Thomas