bug#47969: 28.0.50; Losing minibuffer focus in trying M-x command

[Stefan Monnier]

> I have one more comment: the code that was removed from handle-select-window
> by commit 3fdd3bb56c:
>
> ;; Don't switch if we're currently in the minibuffer.
> ;; This tries to work around problems where the
> ;; minibuffer gets unselected unexpectedly, and where
> ;; you then have to move your mouse all the way down to
> ;; the minibuffer to select it.
> (window-minibuffer-p)

IIUC this condition was tested when we actually tried to select the
other window, i.e. "at the end of `ESC x`".

> was added by that same commit in xterm.c:
>
> /* Don't switch if we're currently in the minibuffer.
>    This tries to work around problems where the
>    minibuffer gets unselected unexpectedly, and where
>    you then have to move your mouse all the way down to
>    the minibuffer to select it.  */
> && !MINI_WINDOW_P (XWINDOW (selected_window))

Whereas this condition is now tested when the mouse movement takes
place, i.e. betwen `ESC` and `x`, at which point the minibuffer is not
yet activated.


        Stefan