bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#48367: 28.0.50; quit-restore-window may jam


From: pillule
Subject: bug#48367: 28.0.50; quit-restore-window may jam
Date: Wed, 12 May 2021 11:25:51 +0000


martin rudalics <rudalics@gmx.at> writes:

The first patch adress this, and a similar one : when there is a previous-buffer available, but it referes to the same buffer. (eg: try the recipe again but exchange the role of *Messages* and *Backtrace*, you will finish with a blank buffer for backtrace, that you can quit again to end up to the same point)

The second patch is a proposition to clarify a little the code.

LGTM. Can you please provide a ChangeLog entry and add a short comment
in the code that mentions the bug number of your report.

Looking at the CONTRIBUTE file, I have done this new version with `git format-patch -l1',
Is that overall better ?

Attachment: quit-restore-window.patch
Description: reformated-patchs


Is that OK to call a cl-lib function in the second patch even if this library is not required in window.el ?


Also, have you signed the copyright agreement for Emacs? How should I
call you in the commit?  "pillule"?

No, I have not yet signed the agreement, I contact assign@gnu.org today to do so. I was hoping sloppily that you consider these contributions as trivial.

If it is fine for you to use my pseudonym, it is fine for me.


--



reply via email to

[Prev in Thread] Current Thread [Next in Thread]