[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#48577: 28.0.50; [PATCH] Lexical binding bug in nnimap-process-expiry
|
From: |
Alex Bochannek |
|
Subject: |
bug#48577: 28.0.50; [PATCH] Lexical binding bug in nnimap-process-expiry-targets |
|
Date: |
Fri, 21 May 2021 16:43:02 -0700 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) |
When using an expiry target mailbox and an IMAP server that does not
support move (Dovecot as per nnimap-quirks), messages will be copied,
but not deleted after expiry.
This was introduced with use of lexical-binding in Gnus and the
difference between set and setq.
The below patch fixes the problem.
diff --git a/lisp/gnus/nnimap.el b/lisp/gnus/nnimap.el
index 570be49094..f869f586d9 100644
--- a/lisp/gnus/nnimap.el
+++ b/lisp/gnus/nnimap.el
@@ -1076,7 +1076,9 @@ nnimap-process-expiry-targets
"UID COPY %s %S")
(nnimap-article-ranges (gnus-compress-sequence articles))
(nnimap-group-to-imap (gnus-group-real-name
nnmail-expiry-target)))
- (set (if can-move 'deleted-articles 'articles-to-delete)
articles))))
+ (if can-move
+ (setq deleted-articles articles)
+ (setq articles-to-delete articles)))))
t)
(t
(dolist (article articles)
--
Alex.