bug#48740: 28.0.50; Composition text property is not always honoured

[Ihor Radchenko]

Eli Zaretskii <eliz@gnu.org> writes:

> It doesn't.  I'm now stuck at step 6, because there's no "item
> selecting "ONGOING" state".  Perhaps because inbox.org says:

Sorry. Probably that instruction is not very clearly written. What I
meant is moving cursor to the first TODO item in the agenda view. Then,
"t n" (switch todo state [t] from TODO to ONGOING [n]). The "t" is
default agenda shortcut to change todo state and "n" is defined in 1.el
as a shortcut to set "ONGOING" state.

>   #+SETUPFILE: /home/yantar92/Org/common.setup

It should not matter here. Also, the instruction have been reproduced by
at least one other user on different machine. See
https://orgmode.org/list/m2o8dbhut7.fsf@gmail.com/

> See above: I'm asking for a simpler test case because IME getting
> stuff this complex to reproduce what you see on your machine is not
> easy and full of frustration.  For example, you assume that the Emacs
> I have installed, the one invoked by "make", is Emacs 28?  But that's
> not what I have here.

I understand your concern and I unfortunately I cannot come up with
anything less complex. Also, I tried to test using Emacs master, Emacs
27, and Emacs 25. I was able to reproduce the issue with all the Emacs
versions.

> Ouch!  No, this doesn't help at all, sorry.  can you tell which of the
> properties in the last step are in effect for the all buffer positions
> of "ONGOING"?

The simplified text properties on the todo-keyword substring are the following:

At step 5 (first build of agenda):
For "TODO":
14 18 (org-heading t org-category \"inbox\" face org-todo fontified t tags 
(...) org-priority-highest 65 org-priority-lowest 67 time-of-day nil duration 
nil breadcrumbs nil txt #(...) level \" \" time \"\" extra \"\" format (...) 
dotime t done-face org-agenda-done org-not-done-regexp \"...\" org-todo-regexp 
\"...\" org-complex-heading-regexp \"...\" mouse-face highlight help-echo 
\"...\" org-marker #<marker (moves after insertion) at 292 in inbox.org> 
org-hd-marker #<marker (moves after insertion) at 292 in inbox.org> priority 
1001 ts-date nil type \"todo\" todo-state #(...) org-agenda-type todo 
org-last-args nil org-redo-cmd (...) org-series-cmd nil)

At step 6 (after changing todo state from TODO to ONGOING):
For "ONG"
14 17 (todo-state #(...) type \"todo\" ts-date nil priority 1001 org-hd-marker 
#<marker (moves after insertion) at 292 in inbox.org> org-marker #<marker 
(moves after insertion) at 292 in inbox.org> help-echo \"...\" mouse-face 
highlight org-complex-heading-regexp \"...\" org-todo-regexp \"...\" 
org-not-done-regexp \"...\" done-face org-agenda-done org-agenda-type todo 
org-last-args nil org-redo-cmd (...) org-series-cmd nil dotime t format (...) 
extra \"\" time \"\" level \" \" txt #(...) breadcrumbs nil duration nil 
time-of-day nil org-priority-lowest 67 org-priority-highest 65 tags (...) 
org-category \"inbox\" face org-todo prettify-symbols-end 301 
prettify-symbols-start 294 composition (0 7 [128119]) org-todo-head #(...) 
fontified t org-heading t)
For "OING"
17 21 (todo-state #(...) type \"todo\" ts-date nil priority 1001 org-hd-marker 
#<marker (moves after insertion) at 292 in inbox.org> org-marker #<marker 
(moves after insertion) at 292 in inbox.org> help-echo \"...\" mouse-face 
highlight org-complex-heading-regexp \"...\" org-todo-regexp \"...\" 
org-not-done-regexp \"...\" done-face org-agenda-done org-agenda-type todo 
org-last-args nil org-redo-cmd (...) org-series-cmd nil dotime t format (...) 
extra \"\" time \"\" level \" \" txt #(...) breadcrumbs nil duration nil 
time-of-day nil org-priority-lowest 67 org-priority-highest 65 tags (...) 
org-category \"inbox\" face org-todo prettify-symbols-end 301 
prettify-symbols-start 294 composition (0 7 [128119]) org-todo-head #(\"TODO\" 
0 4 (face org-todo)) fontified t org-heading t)

Note the composition part: prettify-symbols-end 301 prettify-symbols-start 294 
composition (0 7 [128119])

At step 8 (after org-agenda-redo-all):
For "ONG"
14 17 (org-heading t org-category \"inbox\" face org-todo prettify-symbols-end 
301 prettify-symbols-start 294 composition (0 7 [128119]) org-todo-head #(...) 
fontified t tags (...) org-priority-highest 65 org-priority-lowest 67 
time-of-day nil duration nil breadcrumbs nil txt #(...) level \" \" time \"\" 
extra \"\" format (...) dotime t done-face org-agenda-done org-not-done-regexp 
\"...\" org-todo-regexp \"...\" org-complex-heading-regexp \"...\" mouse-face 
highlight help-echo \"...\" org-marker #<marker (moves after insertion) at 292 
in inbox.org> org-hd-marker #<marker (moves after insertion) at 292 in 
inbox.org> priority 1001 ts-date nil type \"todo\" todo-state #(...) 
org-agenda-type todo org-last-args nil org-redo-cmd (...) org-series-cmd nil)
For "OING"
17 21 (org-heading t org-category \"inbox\" face org-todo prettify-symbols-end 
301 prettify-symbols-start 294 composition (0 7 [128119]) org-todo-head #(...) 
fontified t tags (...) org-priority-highest 65 org-priority-lowest 67 
time-of-day nil duration nil breadcrumbs nil txt #(...) level \" \" time \"\" 
extra \"\" format (...) dotime t done-face org-agenda-done org-not-done-regexp 
\"...\" org-todo-regexp \"...\" org-complex-heading-regexp \"...\" mouse-face 
highlight help-echo \"...\" org-marker #<marker (moves after insertion) at 292 
in inbox.org> org-hd-marker #<marker (moves after insertion) at 292 in 
inbox.org> priority 1001 ts-date nil type \"todo\" todo-state #(...) 
org-agenda-type todo org-last-args nil org-redo-cmd (...) org-series-cmd nil)

Note the composition part: prettify-symbols-end 301 prettify-symbols-start 294 
composition (0 7 [128119])
The composition part remain unchanged except position in the plist.

Best,
Ihor