[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#49963: 28.0.50; isearch failing in Dired after rectangle-mark-mode a
From: |
Eli Zaretskii |
Subject: |
bug#49963: 28.0.50; isearch failing in Dired after rectangle-mark-mode and query-replace |
Date: |
Tue, 10 Aug 2021 19:42:17 +0300 |
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Eli Zaretskii <eliz@gnu.org>, 49963@debbugs.gnu.org, juri@linkov.net,
> laslydone@protonmail.com
> Date: Tue, 10 Aug 2021 11:56:58 -0400
>
> Lars Ingebrigtsen [2021-08-10 17:44:50] wrote:
> > Eli Zaretskii <eliz@gnu.org> writes:
> >> I meant can we please not use add-function and friends. Please?
> > There isn't much difference between using add-function and add-hook most
> > of the time (although here we trip over a `let' binding not doing what
> > the author thought it did).
>
> FWIW, `add-hook` has the exact same problem with `let` (and we already
> tripped against this exact same situation with `add-hook` and `let`).
This is a misunderstanding of what bothers me. The problem is
discoverability: add-function is not easily discoverable, if it is
used on an internal function. IOW, the documentation of C-s doesn't
tell you that its operation could be affected by that "hook". By
contrast, if we use some other mechanism, like call a function via a
variable or call a hook, and if we document these in the doc string of
C-s, that problem will have disappeared, and finding causes of
problems such as this one would be easier.
- bug#49963: 28.0.50; isearch failing in Dired after rectangle-mark-mode and query-replace, laslydone, 2021/08/09
- bug#49963: 28.0.50; isearch failing in Dired after rectangle-mark-mode and query-replace, Juri Linkov, 2021/08/10
- bug#49963: 28.0.50; isearch failing in Dired after rectangle-mark-mode and query-replace, Eli Zaretskii, 2021/08/10
- bug#49963: 28.0.50; isearch failing in Dired after rectangle-mark-mode and query-replace, Stefan Monnier, 2021/08/10
- bug#49963: 28.0.50; isearch failing in Dired after rectangle-mark-mode and query-replace, Eli Zaretskii, 2021/08/10
- bug#49963: 28.0.50; isearch failing in Dired after rectangle-mark-mode and query-replace, Lars Ingebrigtsen, 2021/08/10
- bug#49963: 28.0.50; isearch failing in Dired after rectangle-mark-mode and query-replace, Stefan Monnier, 2021/08/10
- bug#49963: 28.0.50; isearch failing in Dired after rectangle-mark-mode and query-replace,
Eli Zaretskii <=
- bug#49963: 28.0.50; isearch failing in Dired after rectangle-mark-mode and query-replace, Stefan Monnier, 2021/08/10
- bug#49963: 28.0.50; isearch failing in Dired after rectangle-mark-mode and query-replace, Eli Zaretskii, 2021/08/11
- bug#49963: 28.0.50; isearch failing in Dired after rectangle-mark-mode and query-replace, Richard Stallman, 2021/08/10
- bug#49963: 28.0.50; isearch failing in Dired after rectangle-mark-mode and query-replace, Stefan Monnier, 2021/08/11
- bug#49963: 28.0.50; isearch failing in Dired after rectangle-mark-mode and query-replace, Juri Linkov, 2021/08/11
- bug#49963: 28.0.50; isearch failing in Dired after rectangle-mark-mode and query-replace, Eli Zaretskii, 2021/08/10
bug#49963: 28.0.50; isearch failing in Dired after rectangle-mark-mode and query-replace, Stefan Monnier, 2021/08/10