bug#59678: [PATCH] sh-script: use completion-table-with-cache to improve performance

[Yikai Zhao]

On Fri, Dec 2, 2022 at 4:30 AM Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>
> >> I found that the auto-completion on .sh files (with company-mode) was
> >> pretty slow (takes several seconds).  It turns out that company-mode
> >> would call the capf function with 'metadata action for each
> >> candidate, where each function call would need to list all the
> >> cmds. In this patch, I modified the code to use
> >> completion-table-with-cache which fixes the problem for me.
> >
> > Stefan, any comments?
>
> Looks OK to me.  The description of the problem looks concerning, tho:
> if Company really calls the completion table with `metadata` once per
> candidate, then there's a bug in company.

Thanks!

I again confirmed that this is the current behavior.

I created an issue for company-mode to follow up.
https://github.com/company-mode/company-mode/issues/1351

>
>
>         Stefan
>