bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#59833: 29.0.60; json-ts-mode fontifies everything as string


From: Yuan Fu
Subject: bug#59833: 29.0.60; json-ts-mode fontifies everything as string
Date: Mon, 5 Dec 2022 12:22:09 -0800


> On Dec 5, 2022, at 12:19 PM, Randy Taylor <dev@rjt.dev> wrote:
> 
> On Monday, December 5th, 2022 at 15:14, Theodor Thornhill <theo@thornhill.no> 
> wrote:
>> 
>> 
>> On 5 December 2022 20:57:55 CET, Yuan Fu casouri@gmail.com wrote:
>> 
>>>> On Dec 5, 2022, at 7:37 AM, Theodor Thornhill via Bug reports for GNU 
>>>> Emacs, the Swiss army knife of text editors bug-gnu-emacs@gnu.org wrote:
>>>> 
>>>> On 5 December 2022 16:35:12 CET, Randy Taylor dev@rjt.dev wrote:
>>>> 
>>>>> On Monday, December 5th, 2022 at 10:03, Theodor Thornhill 
>>>>> theo@thornhill.no wrote:
>>>>> 
>>>>>> Yeah js-json-mode is a lot simpler, and is imo too simple. The json-mode
>>>>>> is not infact default in emacs, but there are two, one in melpa and one
>>>>>> in elpa, IIRC.
>>>>>> 
>>>>>> Anyway, last patch for now - are you both satisfied with this one?
>>>>>> 
>>>>>> Theo
>>>>> 
>>>>> It's perfect! Sorry for all the trouble :D.
>>>> 
>>>> No problem :)
>>>> 
>>>> Yuan, will you commit this one?
>>> 
>>> Yeah. IIUC :override t is not necessary for pair, right? If so, I’ll apply 
>>> the patch and remove the :override, is that OK?
>>> 
>>> Yuan
>> 
>> 
>> Please test it first, but sure! We want it to not be string face at least :)
>> 
>> Theo
> 
> It's necessary, since string comes first and pair needs to override it (just 
> tested).

Ah, yes, of course, sorry for my ignorance. Applied!

Yuan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]