[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#59888: [PATCH] Add 'grep-heading-mode'
From: |
Augusto Stoffel |
Subject: |
bug#59888: [PATCH] Add 'grep-heading-mode' |
Date: |
Thu, 08 Dec 2022 10:06:58 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
On Wed, 7 Dec 2022 at 16:19, Stefan Kangas wrote:
> Augusto Stoffel <arstoffel@gmail.com> writes:
>
>> From 2247f006845000032fedc3dda9a073b14043a270 Mon Sep 17 00:00:00 2001
>> From: Augusto Stoffel <arstoffel@gmail.com>
>> Date: Wed, 7 Dec 2022 18:44:07 +0100
>> Subject: [PATCH] Add 'grep-heading-mode'
>>
>> New minor mode to subdivide grep output into sections, as in the
>> '--heading' option of certain grep-like programs.
>>
>> * lisp/progmodes/grep.el (grep-heading-regexp): New user option.
>> (grep-heading): New face.
>> (grep--heading-format, grep--current-heading, grep--heading-filter):
>> Filter function for grep processes and supporting variables.
>> (grep-heading-mode): New minor mode.
>
> How about making this into a defcustom instead of a minor mode?
>
> I'm thinking that something like
>
> (setopt grep-use-headings t)
>
> is a slightly simpler interface to use than
>
> (add-hook 'grep-mode-hook 'grep-heading-mode)
>
> I also think the former plays a bit better with customize.
This is at the same time less customizable in the sense that something
like
(add-hook 'grep-mode-hook
(lambda () (when condition) (setq grep-use-headings t)))
will not work (I think), while conditionally activating a minor mode
certainly works. But I'm open to both approaches.
- bug#59888: [PATCH] Add 'grep-heading-mode', Augusto Stoffel, 2022/12/07
- bug#59888: [PATCH] Add 'grep-heading-mode', Eli Zaretskii, 2022/12/07
- bug#59888: [PATCH] Add 'grep-heading-mode', Stefan Kangas, 2022/12/07
- bug#59888: [PATCH] Add 'grep-heading-mode',
Augusto Stoffel <=
- bug#59888: [PATCH] Add 'grep-heading-mode', Juri Linkov, 2022/12/09
- bug#59888: [PATCH] Add 'grep-heading-mode', Augusto Stoffel, 2022/12/09
- bug#59888: [PATCH] Add 'grep-use-headings', Augusto Stoffel, 2022/12/09
- bug#59888: [PATCH] Add 'grep-use-headings', Eli Zaretskii, 2022/12/09
- bug#59888: [PATCH] Add 'grep-use-headings', Augusto Stoffel, 2022/12/09
- bug#59888: [PATCH] Add 'grep-use-headings', Eli Zaretskii, 2022/12/09
- bug#59888: [PATCH] Add 'grep-use-headings', Augusto Stoffel, 2022/12/10
- bug#59888: [PATCH] Add 'grep-use-headings', Eli Zaretskii, 2022/12/10
- bug#59888: [PATCH] Add 'grep-use-headings', Augusto Stoffel, 2022/12/11
- bug#59888: [PATCH] Add 'grep-use-headings', Juri Linkov, 2022/12/15