bug#59906: 29.0.60; typescript-ts-mode is not highlighting escape sequences

[Yuan Fu]

Jostein Kjønigsen <jostein@secure.kjonigsen.net> writes:

> On 08.12.2022 16:19, Theodor Thornhill wrote:
>> Jostein Kjønigsen <jostein@secure.kjonigsen.net> writes:
>>
>>> In a buffer with typescript-ts-mode activated, write the following code:
>>>
>>> const test = "quoted\"string\" contents";
>>>
>>> The entire text, include the \" is highlighted as strings, and escape 
>>> sequences are not handled:
>>>
>>> This code has the following tree-sitter syntax tree:
>>>
>>>   (lexical_declaration kind: const
>>>    (variable_declarator name: (identifier) value: =
>>>     (string " (string_fragment) (escape_sequence) (string_fragment) 
>>> (escape_sequence) (string_fragment) "))
>>>    ;)
>>>
>>> In typescript-ts-mode we seemingly have rules to handle fontification of 
>>> escape sequences:
>>>
>>>      :language language
>>>      :feature 'escape-sequence
>>>      :override t
>>>      '((escape_sequence) @font-lock-escape-face))
>>>
>>> This feature is however not activated in the major-mode setup:
>>>
>>>       (setq-local treesit-font-lock-feature-list
>>>                   '((comment declaration)
>>>                     (keyword string)
>>>                     (constant expression identifier number pattern property)
>>>                     (bracket delimiter)))
>>>
>>> Naively I assumed that simply adding this feature would activate this rule, 
>>> but still \" is fontified as string.
>> Yeah, there was an error there.  See below patch.
>>
>> Yuan, can you install this?
>>
>> Theo
>>
> Yeah that works for me.
>
> Yuan: another vote for installing right here :)

Yep, applied, many thanks!

Yuan