bug#58919: 28.2; dired-copy-file-recursive fails to overwrite directory

[Eli Zaretskii]

Ping!

Paul, did you have an opportunity to come up with the patch you
mentioned in this discussion?  I'd like to solve this bug for Emacs
29, please.

> From: Michael Albinus <michael.albinus@gmx.de>
> Date: Tue, 01 Nov 2022 20:21:32 +0100
> Cc: Thierry Volpiatto <thievol@posteo.net>, 58919@debbugs.gnu.org,
>  Eli Zaretskii <eliz@gnu.org>
> 
> Paul Eggert <eggert@cs.ucla.edu> writes:
> 
> Hi Paul,
> 
> > The simplest fix I can see is to enhance make-directory so that it
> > returns t if the directory already existed and PARENTS was given, nil
> > on any other successful return. This would require changes to Tramp to
> > avoid races there. I plan to post a proposed patch for comment.
> 
> To make it more fun, there are several Tramp implementations of that
> function, and also other ones. Xref, running in the lisp/ tree for
> "defun.*make-directory", returns
> 
> --8<---------------cut here---------------start------------->8---
> lisp/dired.el
> 1911: (defun dired--make-directory-clickable ()
> lisp/files.el
> 6203: (defun make-directory (dir &optional parents)
> lisp/gnus/gnus-group.el
> 3120: (defun gnus-group-make-directory-group (dir)
> lisp/gnus/gnus-util.el
> 726: (defun gnus-make-directory (directory)
> lisp/htmlfontify.el
> 1844: (defun hfy-make-directory (dir)
> lisp/ido.el
> 2994: (defun ido-make-directory (&optional dir)
> lisp/net/ange-ftp.el
> 4125: (defun ange-ftp-make-directory (dir &optional parents)
> 4530: (defun ange-ftp-real-make-directory (&rest args)
> lisp/net/tramp-adb.el
> 411: (defun tramp-adb-handle-make-directory (dir &optional parents)
> lisp/net/tramp-crypt.el
> 800: (defun tramp-crypt-handle-make-directory (dir &optional parents)
> lisp/net/tramp-fuse.el
> 128: (defun tramp-fuse-handle-make-directory (dir &optional parents)
> lisp/net/tramp-gvfs.el
> 1560: (defun tramp-gvfs-handle-make-directory (dir &optional parents)
> lisp/net/tramp-sh.el
> 2559: (defun tramp-sh-handle-make-directory (dir &optional parents)
> lisp/net/tramp-smb.el
> 1172: (defun tramp-smb-handle-make-directory (dir &optional parents)
> 1192: (defun tramp-smb-handle-make-directory-internal (directory)
> lisp/net/tramp-sudoedit.el
> 626: (defun tramp-sudoedit-handle-make-directory (dir &optional parents)
> lisp/obsolete/autoload.el
> 725: (defun make-directory-autoloads (dir output-file)
> lisp/url/url-dav.el
> 761: (defun url-dav-make-directory (url &optional _parents)
> --8<---------------cut here---------------end--------------->8---
> 
> Best regards, Michael.
> 
> 
> 
>