bug#59979: 30.0.50; dockerfile-ts-mode imenu issue

[Randy Taylor]

On Monday, December 12th, 2022 at 03:28, Eshel Yaron via "Bug reports for GNU 
Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org> wrote:
> 
> Randy Taylor dev@rjt.dev writes:
> 
> > On Sunday, December 11th, 2022 at 18:57, Randy Taylor dev@rjt.dev wrote:
> > 
> > I didn't notice this because I use conult-imenu, which will add an
> > index for any duplicates. imenu doesn't do this, and for other modes
> > like c-mode, c++-mode, org-mode, etc., only the first entry gets
> > shown.
> > 
> > I've attached a patch which will use the stage name if it's available,
> > otherwise use the base image.
> 
> 
> Great :) That's certainly an improvement.
> 
> I still maintain that using the base image as an identifier of the build
> stage is not that useful, it doesn't really identify the stage in any
> way, like identifying functions their arguments doesn't make a lot of
> sense. I do see how in practice that'll probably be fine in most cases.
> 

We don't get any information about which stage is which beyond the base image 
and potential alias (which is all Dockerfiles themselves have anyway), so we 
would need to track that stuff ourselves, and I don't think it's worth the 
complexity. Dockerfiles give us a solution to this anyway: use aliases.

Perhaps consider trying a different imenu implementation? I use consult-imenu 
which gives indexes for any duplicates (it also flattens imenu which I really 
like). Maybe someone could add something like that to imenu.

Can someone install the patch? Thanks.