bug#59918: 29.0.60; query-replace in the minibuffer lazy-highlights original buffer

[Eli Zaretskii]

> From: Augusto Stoffel <arstoffel@gmail.com>
> Cc: juri@linkov.net,  59918@debbugs.gnu.org
> Date: Mon, 12 Dec 2022 23:42:46 +0100
> 
> On Mon, 12 Dec 2022 at 21:28, Eli Zaretskii wrote:
> 
> > OK, so we must fix it on the emacs-29 branch.  What remains is to
> > decide what fix to use.
> 
> This one :-)
> 
> >From bcebf9622bc11cb36e0a56bc1874f24cfa634210 Mon Sep 17 00:00:00 2001
> From: Augusto Stoffel <arstoffel@gmail.com>
> Date: Mon, 12 Dec 2022 23:07:28 +0100
> Subject: [PATCH] Don't allow lazy highlight from recursive minibuffers
> 
> See bug#59918.
> 
> * lisp/isearch.el (minibuffer-lazy-highlight-setup): Don't activate
> when starting a recursive minibuffer.
> ---
>  lisp/isearch.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lisp/isearch.el b/lisp/isearch.el
> index bc3697deb0a..6a17d18c45e 100644
> --- a/lisp/isearch.el
> +++ b/lisp/isearch.el
> @@ -4435,7 +4435,7 @@ minibuffer-lazy-highlight-setup
>  highlighting.
>  LAX-WHITESPACE: The value of `isearch-lax-whitespace' and
>  `isearch-regexp-lax-whitespace' to use for lazy highlighting."
> -  (if (not highlight)
> +  (if (or (not highlight) (minibufferp))
>        #'ignore
>      (let ((unwind (make-symbol "minibuffer-lazy-highlight--unwind"))
>            (after-change (make-symbol 
> "minibuffer-lazy-highlight--after-change"))

This is fine with me, but AFAIU it means that replacements in the
minibuffer will never be highlighted, ever.  Is that what we want?  I
thought Juri wanted to see highlighting there?