[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#60015: 29.0.60; multi-line messages truncated in non-selected minibu
From: |
Eli Zaretskii |
Subject: |
bug#60015: 29.0.60; multi-line messages truncated in non-selected minibuffer |
Date: |
Thu, 15 Dec 2022 19:03:30 +0200 |
> Date: Thu, 15 Dec 2022 16:44:29 +0000
> From: Gregory Heytings <gregory@heytings.org>
> cc: Eli Zaretskii <eliz@gnu.org>, 60015@debbugs.gnu.org
>
> Is this not something that can be solved in set-minibuffer-message, like
> this:
>
> diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
> index 6e42296e7ba..c10a6401180 100644
> --- a/lisp/minibuffer.el
> +++ b/lisp/minibuffer.el
> @@ -817,6 +817,11 @@ set-minibuffer-message
> ;; Make sure we can put-text-property.
> (copy-sequence message)
> (concat " [" message "]")))
> + (let ((window-lines (window-height minibuf-window))
> + (message-lines (length (split-string message "\n"))))
> + (when (> message-lines window-lines)
> + (with-selected-window minibuf-window
> + (enlarge-window (- message-lines window-lines)))))
> (unless (or (null minibuffer-message-properties)
> ;; Don't overwrite the face properties the caller has
> set
> (text-properties-at 0 message))
This won't catch the case of a single very long line (which wraps to
produce several screen lines).
Also, unconditionally enlarging the mini-window is not a good idea
because it might already be tall enough. Try the above in the recipe
posted by Juri, but then type "C-c C-c" several times -- doesn't it
keep enlarging the mini-window with each "C-c C-c"?
- bug#60015: 29.0.60; multi-line messages truncated in non-selected minibuffer, (continued)
- bug#60015: 29.0.60; multi-line messages truncated in non-selected minibuffer, Juri Linkov, 2022/12/13
- bug#60015: 29.0.60; multi-line messages truncated in non-selected minibuffer, Juri Linkov, 2022/12/15
- bug#60015: 29.0.60; multi-line messages truncated in non-selected minibuffer, martin rudalics, 2022/12/15
- bug#60015: 29.0.60; multi-line messages truncated in non-selected minibuffer, Eli Zaretskii, 2022/12/15
- bug#60015: 29.0.60; multi-line messages truncated in non-selected minibuffer, Eli Zaretskii, 2022/12/15
- bug#60015: 29.0.60; multi-line messages truncated in non-selected minibuffer, martin rudalics, 2022/12/15
- bug#60015: 29.0.60; multi-line messages truncated in non-selected minibuffer, martin rudalics, 2022/12/15
- bug#60015: 29.0.60; multi-line messages truncated in non-selected minibuffer, Eli Zaretskii, 2022/12/15
- bug#60015: 29.0.60; multi-line messages truncated in non-selected minibuffer, Juri Linkov, 2022/12/15
- bug#60015: 29.0.60; multi-line messages truncated in non-selected minibuffer, Gregory Heytings, 2022/12/15
- bug#60015: 29.0.60; multi-line messages truncated in non-selected minibuffer,
Eli Zaretskii <=
- bug#60015: 29.0.60; multi-line messages truncated in non-selected minibuffer, Juri Linkov, 2022/12/15
- bug#60015: 29.0.60; multi-line messages truncated in non-selected minibuffer, Gregory Heytings, 2022/12/15