bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#59956: 29.0.60: Failure when completing arguments in Eshell after va


From: Jim Porter
Subject: bug#59956: 29.0.60: Failure when completing arguments in Eshell after variable interpolation
Date: Thu, 15 Dec 2022 22:09:10 -0800

On 12/12/2022 2:21 PM, Gregory Heytings wrote:
I'm still not Stefan, but this bug is fixed by the attached patch.

Thanks. This is pretty close to what I was thinking (I tried almost the exact same patch locally, but wasn't sure if there was a better way). Personally, I think something like your patch would probably be the safest bet for the 29 branch.

Still, like Stefan and Augusto mentioned, there's probably a larger issue here: should Eshell be allowed to feed Pcomplete non-strings? Since Pcomplete was written for Eshell initially, there's some basis for why it *might* support non-string values, but actually requiring that is an awful lot to ask of every programmer who ever wants to write a pcomplete function.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]