bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#60105: [PATCH] Add yaml-ts-mode


From: Yuan Fu
Subject: bug#60105: [PATCH] Add yaml-ts-mode
Date: Fri, 16 Dec 2022 14:55:34 -0800

Randy Taylor <dev@rjt.dev> writes:

> On Thursday, December 15th, 2022 at 19:20, Stefan Kangas 
> <stefankangas@gmail.com> wrote:
>> 
>> Randy Taylor dev@rjt.dev writes:
>> 
>> > diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
>> > index 9c5a361df7..4319623e64 100644
>> > --- a/lisp/progmodes/eglot.el
>> > +++ b/lisp/progmodes/eglot.el
>> > @@ -224,7 +224,7 @@ eglot-server-programs
>> > ((tex-mode context-mode texinfo-mode bibtex-mode)
>> > . ,(eglot-alternatives '("digestif" "texlab")))
>> > (erlang-mode . ("erlang_ls" "--transport" "stdio"))
>> > - (yaml-mode . ("yaml-language-server" "--stdio"))
>> > + ((yaml-mode yaml-ts-mode) . ("yaml-language-server" "--stdio"))
>> 
>> 
>> This is a nit, but I think it might make more sense to users if we put
>> the built-in mode first in the list. After all, the one we ship with
>> Emacs is, or will be, the standard mode.
>
> Sounds good to me. I'll submit another patch tomorrow making that change for 
> the rest of the modes we've added (unless someone beats me to it).
>
> Attached is a new patch that applies cleanly against emacs-29 and has 
> yaml-ts-mode come first for eglot.
>

LGTM, I applied the patch, thanks!

Yuan





reply via email to

[Prev in Thread] Current Thread [Next in Thread]