bug#60296: Re: bug#60296: The imenu is not created properly in c-ts-mode

[address@hidden]

>> On Dec 24, 2022, at 10:53 PM, Eli Zaretskii <eliz@gnu.org> wrote:

>>

>>> Cc: 60296-done@debbugs.gnu.org

>>> From: Yuan Fu <casouri@gmail.com>

>>> Date: Sat, 24 Dec 2022 19:00:21 -0800

>>>

>>>> From: sniper <e190@163.com>

>>>> To: bug-gnu-emacs@gnu.org

>>>> Subject: 29.0.60; The imenu is not created properly in c-ts-mode.

>>>>

>>>> ``` c

>>>> char *test(int size){

>>>> return NULL;

>>>> }

>>>> ```

>>>> If c-ts-mode is enabled in a c file, the imenu created will be [` test(int size)`] if the return type of the function is a

>>>> pointer.

>>>> The expected display should just be the function name [` test `], with no subsequent arguments

>>>

>>> Thanks, this should be fixed now.

>>

>> This change leads to

>>

>>  In c-ts-mode--fontify-declarator:

>>  progmodes/c-ts-mode.el:405:69: Warning: Unused lexical argument `args'

>>

>> And "&rest args" is indeed unused there, AFAICT.

 

>My bad. I’ve fixed that by changing args to _.

Hi, Yuan:

I tested it in the latest version and found several more issues.

``` c

int main(int argc, char *argv[])

{

.....

   struct name_t name = (struct name_t)name;

   name.a = sizeof(struct name_t);

.....

}

```

If Forced conversion or ` sizeof(struct name_t) ` occurs in a function, it will occur in the Struct entry of imenu.

``` c

int func_1(int v); // <-- function declaration

int main(int argc, char *argv[])

{

}

```

If there is a function declaration in the c file, it will also appear in imenu's Variable entry.

---

e190@163.com

 

From: Yuan Fu

Date: 2022-12-25 16:31

To: Eli Zaretskii

CC: 60296; e190

Subject: Re: bug#60296: The imenu is not created properly in c-ts-mode

 

 

> On Dec 24, 2022, at 10:53 PM, Eli Zaretskii <eliz@gnu.org> wrote:

>

>> Cc: 60296-done@debbugs.gnu.org

>> From: Yuan Fu <casouri@gmail.com>

>> Date: Sat, 24 Dec 2022 19:00:21 -0800

>>

>>> From: sniper <e190@163.com>

>>> To: bug-gnu-emacs@gnu.org

>>> Subject: 29.0.60; The imenu is not created properly in c-ts-mode.

>>>

>>> ``` c

>>> char *test(int size){

>>> return NULL;

>>> }

>>> ```

>>> If c-ts-mode is enabled in a c file, the imenu created will be [` test(int size)`] if the return type of the function is a

>>> pointer.

>>> The expected display should just be the function name [` test `], with no subsequent arguments

>>

>> Thanks, this should be fixed now.

>

> This change leads to

>

>  In c-ts-mode--fontify-declarator:

>  progmodes/c-ts-mode.el:405:69: Warning: Unused lexical argument `args'

>

> And "&rest args" is indeed unused there, AFAICT.

 

My bad. I’ve fixed that by changing args to _.

 

Yuan