[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#60321: 29.0.60; ruby-mode indentation of hash or array as first arg
From: |
Aaron Jensen |
Subject: |
bug#60321: 29.0.60; ruby-mode indentation of hash or array as first arg in multiline method call |
Date: |
Mon, 26 Dec 2022 20:38:03 -0500 |
On Mon, Dec 26, 2022 at 8:16 PM Dmitry Gutov <dgutov@yandex.ru> wrote:
>
> Vim's choice looks saner to my eye. Probably comes down to the choice of
> indentation algorithm, though.
Agreed, though it's hard to pick which is more sane when all the
options start with insanity.
> > If I had to type it as above, I would probably indent it like this:
> >
> > and_in_a_method_call({
> > no: :difference
> > },
> > foo,
> > bar)
> >
> > But I can't imagine that would be easy to implement at all, so I
> > wouldn't bother.
>
> The indentation logic itself might be not that difficult to write, but
> the fact that the expression will have to be reindented as soon as the
> method call grows a second argument (after the user types the comma?),
> makes it a hard sell usability-wise.
Right, I think that's just more of the same thing... We are looking at
ways of writing code that are out of the realm of reason. It's a
challenge to define behavior when the behavior could very well be
undefined. But, if we must define it, then what are our guiding
principles? Not having to reindent preceding lines when adding a new
line may be a very reasonable one. In that case, the only two options
I could think of would be:
and_in_a_method_call({
no: :difference
},
foo,
bar)
or
and_in_a_method_call({
no: :difference
},
foo,
bar)
The difference being if we decide to dedent upon the last closing
indent-requiring-token or the first.
I think a reasonable rule of thumb for a human might be: "If you open
N indents on one line, you must close N indents on one line". Any time
you stray away from this, behavior becomes... not ideal.
Aaron
- bug#60186: 29.0.60; ruby-mode indentation of multi-line expressions, (continued)
- bug#60186: 29.0.60; ruby-mode indentation of multi-line expressions, Dmitry Gutov, 2022/12/22
- bug#60186: 29.0.60; ruby-mode indentation of multi-line expressions, Aaron Jensen, 2022/12/22
- bug#60186: 29.0.60; ruby-mode indentation of multi-line expressions, Dmitry Gutov, 2022/12/23
- bug#60186: 29.0.60; ruby-mode indentation of multi-line expressions, Aaron Jensen, 2022/12/23
- bug#60186: 29.0.60; ruby-mode indentation of multi-line expressions, Dmitry Gutov, 2022/12/24
- bug#60186: 29.0.60; ruby-mode indentation of multi-line expressions, Aaron Jensen, 2022/12/24
- bug#60186: 29.0.60; ruby-mode indentation of multi-line expressions, Dmitry Gutov, 2022/12/25
- bug#60321: 29.0.60; ruby-mode indentation of hash or array as first arg in multiline method call, Dmitry Gutov, 2022/12/25
- bug#60321: 29.0.60; ruby-mode indentation of hash or array as first arg in multiline method call, Aaron Jensen, 2022/12/25
- bug#60321: 29.0.60; ruby-mode indentation of hash or array as first arg in multiline method call, Dmitry Gutov, 2022/12/26
- bug#60321: 29.0.60; ruby-mode indentation of hash or array as first arg in multiline method call,
Aaron Jensen <=
- bug#60186: 29.0.60; ruby-mode indentation of multi-line expressions, Aaron Jensen, 2022/12/24
- bug#60186: 29.0.60; ruby-mode indentation of multi-line expressions, Dmitry Gutov, 2022/12/25
- bug#60186: 29.0.60; ruby-mode indentation of multi-line expressions, Dmitry Gutov, 2022/12/26
- bug#60186: 29.0.60; ruby-mode indentation of multi-line expressions, Aaron Jensen, 2022/12/26
- bug#60186: 29.0.60; ruby-mode indentation of multi-line expressions, Dmitry Gutov, 2022/12/27
- bug#60186: 29.0.60; ruby-mode indentation of multi-line expressions, Aaron Jensen, 2022/12/27
- bug#60186: 29.0.60; ruby-mode indentation of multi-line expressions, Dmitry Gutov, 2022/12/27
- bug#60186: 29.0.60; ruby-mode indentation of multi-line expressions, Aaron Jensen, 2022/12/27
- bug#60186: 29.0.60; ruby-mode indentation of multi-line expressions, Dmitry Gutov, 2022/12/27
- bug#60186: 29.0.60; ruby-mode indentation of multi-line expressions, Aaron Jensen, 2022/12/27