[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#60398: 29.0.60; c++-ts-mode: Strange indentation of function body wh
From: |
Theodor Thornhill |
Subject: |
bug#60398: 29.0.60; c++-ts-mode: Strange indentation of function body when parameter list has newline |
Date: |
Thu, 29 Dec 2022 11:45:47 +0100 |
Yuan Fu <casouri@gmail.com> writes:
>> On Dec 28, 2022, at 11:49 PM, Knut Anders Hatlen <kahatlen@gmail.com> wrote:
>>
>>
>> Function bodies are indented strangely in c++-ts-mode if the parameter
>> list has a newline between two parameters. For example:
>>
>> int f1(int x, int y) {
>> // Indented as expected.
>> return x + y;
>> }
>>
>> int f2(int x,
>> int y) {
>> // Indented too much.
>> return x + y;
>> };
>
> I implemented a fix in 784e509bded, Theo, WDYT? Could this be used on other
> C-like modes, too?
>
LGTM!
I believe that should work for most other cases of this, but IIRC there
are some cases where the compound statements are considered as siblings,
not children, but I forgot what it was exactly...
But I think this should work in most cases, at least!
Theo