[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#60411: 29.0.60; minibuffer-next-completion skips first candidate whe
From: |
Stefan Monnier |
Subject: |
bug#60411: 29.0.60; minibuffer-next-completion skips first candidate when completions-header-format and completion-show-help are nil |
Date: |
Sun, 01 Jan 2023 12:00:25 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
> @@ -2275,8 +2275,14 @@ display-completion-list
>
> (with-current-buffer standard-output
> (goto-char (point-max))
> - (when completions-header-format
> + (when (stringp completions-header-format)
> (insert (format completions-header-format (length completions))))
> + (when (or (not (stringp completions-header-format))
> + (string= completions-header-format ""))
> + ;; Insert an invisible line, otherwise the first call to
> + ;; 'minibuffer-next-completion' might select the second
> + ;; completion candidate. See bug#60411.
> + (insert (propertize "\n" 'invisible t)))
> (completion--insert-strings completions group-fun)))
>
> (run-hooks 'completion-setup-hook)
Yuck. I get the impression that it would be cleaner to fix "the first
call to `minibuffer-next-completion`" instead.
Stefan
- bug#60411: 29.0.60; minibuffer-next-completion skips first candidate when completions-header-format and completion-show-help are nil,
Stefan Monnier <=
- bug#60411: 29.0.60; minibuffer-next-completion skips first candidate when completions-header-format and completion-show-help are nil, Gregory Heytings, 2023/01/01
- bug#60411: 29.0.60; minibuffer-next-completion skips first candidate when completions-header-format and completion-show-help are nil, Stefan Monnier, 2023/01/01
- bug#60411: 29.0.60; minibuffer-next-completion skips first candidate when completions-header-format and completion-show-help are nil, Gregory Heytings, 2023/01/01
- bug#60411: 29.0.60; minibuffer-next-completion skips first candidate when completions-header-format and completion-show-help are nil, Juri Linkov, 2023/01/05
- bug#60411: 29.0.60; minibuffer-next-completion skips first candidate when completions-header-format and completion-show-help are nil, Gregory Heytings, 2023/01/05
- bug#60411: 29.0.60; minibuffer-next-completion skips first candidate when completions-header-format and completion-show-help are nil, Eli Zaretskii, 2023/01/06
- bug#60411: 29.0.60; minibuffer-next-completion skips first candidate when completions-header-format and completion-show-help are nil, Gregory Heytings, 2023/01/06
- bug#60411: 29.0.60; minibuffer-next-completion skips first candidate when completions-header-format and completion-show-help are nil, Eli Zaretskii, 2023/01/06
- bug#60411: 29.0.60; minibuffer-next-completion skips first candidate when completions-header-format and completion-show-help are nil, Gregory Heytings, 2023/01/06
- bug#60411: 29.0.60; minibuffer-next-completion skips first candidate when completions-header-format and completion-show-help are nil, Eli Zaretskii, 2023/01/06