[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#60210: 30.0.50; tab-bar height not recalculated when face changes
From: |
Eli Zaretskii |
Subject: |
bug#60210: 30.0.50; tab-bar height not recalculated when face changes |
Date: |
Mon, 02 Jan 2023 17:05:49 +0200 |
> Date: Sun, 01 Jan 2023 21:50:56 +0000
> From: Gregory Heytings <gregory@heytings.org>
> cc: 60210@debbugs.gnu.org, juri@linkov.net
>
> > I'm not sure I understand how the above causes the tab bar not to be
> > displayed, or become empty. AFAIU, it just means the frame's
> > change_tab_bar_height_hook will be called. What did I miss?
> >
>
> I do not fully understand it either yet. A simpler recipe, which does not
> involve changing fonts:
>
> (set-face-attribute 'tab-bar nil :height 0.5)
> (tab-bar-mode 1)
>
> This should display a tiny tab-bar, it displays a white bar instead.
>
> In redisplay_tab_bar, new_height is set to half the height of a canonical
> line (17 and 34 on my system). Therefore redisplay_tab_bar returns true.
> The next redisplay cycle finds that WINDOW_TOTAL_LINES (w) == 0, and does
> nothing.
Thanks, I hope I fixed this now on emacs-29, please re-test.