[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#60467: 30.0.50; primitive-undo: Changes to be undone by function dif
From: |
Gregory Heytings |
Subject: |
bug#60467: 30.0.50; primitive-undo: Changes to be undone by function different from announced |
Date: |
Tue, 03 Jan 2023 09:41:52 +0000 |
It turns out that the bug is indeed not in Org, but in Emacs. The part of
combine-change-call which creates the undo-list element was totally
broken. For example, with a buffer-undo-list like
<undo element 1> <timestamp> <undo element 2> <timestamp> nil <undo element 3>
ofter body has been evaluated, the buffer-undo-list after
combine-change-call is
(apply ... #'undo--wrap-and-run-primitive-undo ... (<undo element 1>)) <timestamp> <undo
element 2> <timestamp> nil <undo element 3>
which is clearly wrong, because <undo element 1> and <undo element 2>
should be considered as a single undo step. IOW, after
combine-change-call buffer-undo-list should be:
(apply ... #'undo--wrap-and-run-primitive-undo ... (<undo element 1> <undo element
2>)) nil <undo element 3>
Patch attached.
Fix-combine-change-call.patch
Description: Text Data
- bug#60467: 30.0.50; primitive-undo: Changes to be undone by function different from announced, Ihor Radchenko, 2023/01/01
- bug#60467: 30.0.50; primitive-undo: Changes to be undone by function different from announced, Eli Zaretskii, 2023/01/01
- bug#60467: 30.0.50; primitive-undo: Changes to be undone by function different from announced, Gregory Heytings, 2023/01/01
- bug#60467: 30.0.50; primitive-undo: Changes to be undone by function different from announced, Gregory Heytings, 2023/01/01
- bug#60467: 30.0.50; primitive-undo: Changes to be undone by function different from announced, Ihor Radchenko, 2023/01/02
- bug#60467: 30.0.50; primitive-undo: Changes to be undone by function different from announced,
Gregory Heytings <=
- bug#60467: 30.0.50; primitive-undo: Changes to be undone by function different from announced, Eli Zaretskii, 2023/01/03
- bug#60467: 30.0.50; primitive-undo: Changes to be undone by function different from announced, Gregory Heytings, 2023/01/03
- bug#60467: 30.0.50; primitive-undo: Changes to be undone by function different from announced, Eli Zaretskii, 2023/01/03
- bug#60467: 30.0.50; primitive-undo: Changes to be undone by function different from announced, Gregory Heytings, 2023/01/03
- bug#60467: 30.0.50; primitive-undo: Changes to be undone by function different from announced, Stefan Monnier, 2023/01/03
- bug#60467: 30.0.50; primitive-undo: Changes to be undone by function different from announced, Gregory Heytings, 2023/01/03
- bug#60467: 30.0.50; primitive-undo: Changes to be undone by function different from announced, Gregory Heytings, 2023/01/03
- bug#60467: 30.0.50; primitive-undo: Changes to be undone by function different from announced, Gregory Heytings, 2023/01/03
- bug#60467: 30.0.50; primitive-undo: Changes to be undone by function different from announced, Stefan Monnier, 2023/01/03
- bug#60467: 30.0.50; primitive-undo: Changes to be undone by function different from announced, Gregory Heytings, 2023/01/04