[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#60464: 29.0.60; Regression - pcomplete-arg fails with argument 'last
From: |
Daniel Mendler |
Subject: |
bug#60464: 29.0.60; Regression - pcomplete-arg fails with argument 'last |
Date: |
Wed, 4 Jan 2023 16:22:53 +0100 |
On 1/4/23 16:18, Eli Zaretskii wrote:
>> Date: Wed, 4 Jan 2023 16:14:14 +0100
>> Cc: Stefan Monnier <monnier@iro.umontreal.ca>,
>> Jim Porter <jporterbugs@gmail.com>, Eli Zaretskii <eliz@gnu.org>,
>> 60464@debbugs.gnu.org
>> From: Daniel Mendler <mail@daniel-mendler.de>
>>
>> Your implementation with the 'last condition doesn't make sense.
>
> "Doesn't make sense" is a harsh judgment of someone's code, and I have
> hard time believing Gregory's deserves that. Please try to be kinder
> in how you express your disagreements with someone else's code.
I try to formulate it more fairly. In my opinion Gregory's patches so
far did not fix the issue in a way which is future-proof. The first
prematurely installed patch was obviously broken. The current proposal
introduces an unexpected special casing, where it would be better if the
function behaves uniformly for all arguments.
Daniel
- bug#60464: 29.0.60; Regression - pcomplete-arg fails with argument 'last, (continued)
- bug#60464: 29.0.60; Regression - pcomplete-arg fails with argument 'last, Jim Porter, 2023/01/04
- bug#60464: 29.0.60; Regression - pcomplete-arg fails with argument 'last, Gregory Heytings, 2023/01/04
- bug#60464: 29.0.60; Regression - pcomplete-arg fails with argument 'last, Stefan Monnier, 2023/01/04
- bug#60464: 29.0.60; Regression - pcomplete-arg fails with argument 'last, Daniel Mendler, 2023/01/04
- bug#60464: 29.0.60; Regression - pcomplete-arg fails with argument 'last, Gregory Heytings, 2023/01/04
- bug#60464: 29.0.60; Regression - pcomplete-arg fails with argument 'last, Daniel Mendler, 2023/01/04
- bug#60464: 29.0.60; Regression - pcomplete-arg fails with argument 'last, Eli Zaretskii, 2023/01/04
- bug#60464: 29.0.60; Regression - pcomplete-arg fails with argument 'last,
Daniel Mendler <=
- bug#60464: 29.0.60; Regression - pcomplete-arg fails with argument 'last, Gregory Heytings, 2023/01/04
- bug#60464: 29.0.60; Regression - pcomplete-arg fails with argument 'last, Daniel Mendler, 2023/01/04
- bug#60464: 29.0.60; Regression - pcomplete-arg fails with argument 'last, Stefan Monnier, 2023/01/04
- bug#60464: 29.0.60; Regression - pcomplete-arg fails with argument 'last, Gregory Heytings, 2023/01/04
- bug#60464: 29.0.60; Regression - pcomplete-arg fails with argument 'last, Gregory Heytings, 2023/01/14
- bug#60464: 29.0.60; Regression - pcomplete-arg fails with argument 'last, Jim Porter, 2023/01/04
- bug#60464: 29.0.60; Regression - pcomplete-arg fails with argument 'last, Jim Porter, 2023/01/04
- bug#60464: 29.0.60; Regression - pcomplete-arg fails with argument 'last, Gregory Heytings, 2023/01/04
- bug#60464: 29.0.60; Regression - pcomplete-arg fails with argument 'last, Daniel Mendler, 2023/01/04
- bug#60464: 29.0.60; Regression - pcomplete-arg fails with argument 'last, Eli Zaretskii, 2023/01/04