bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#58950: [PATCH] * lisp/subr.el (buffer-match-p): Optimise performance


From: Dmitry Gutov
Subject: bug#58950: [PATCH] * lisp/subr.el (buffer-match-p): Optimise performance
Date: Thu, 5 Jan 2023 14:55:06 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2

On 05/01/2023 12:31, Mattias Engdegård wrote:
5 jan. 2023 kl. 05.31 skrev Stefan Monnier<monnier@iro.umontreal.ca>:

I don't much like the kind of mini-language we invented for
`buffer-match-p`.  I'd prefer we just used plain old ELisp for that.
Yes, I sort of wondered whether we were going full Greenspun here. We haven't 
added many embedded languages into our embedded language lately.

The usual DSL worthiness criteria:

- more expressive than plain code for the domain
- potential for significantly better performance
- better error-checking, statically or dynamically
- structured editing

etc, don't really seem to be met here but I'm not deeply familiar with the 
problem and perhaps the author could make a better case for it.

Note that we already had ah-hoc and informally-specified pieces of such DSL before, in font-lock-global-modes and display-buffer-alist. The new use in show-paren-predicate seems fitting too.

I'm not sure how we'd reach the same goals with plain old Elisp (structured editing in particular -- in Customize).





reply via email to

[Prev in Thread] Current Thread [Next in Thread]