bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#60659: 30.0.50; tree-sitter: identical nodes are not `equal'


From: Yuan Fu
Subject: bug#60659: 30.0.50; tree-sitter: identical nodes are not `equal'
Date: Mon, 9 Jan 2023 21:56:19 -0800

Mickey Petersen <mickey@masteringemacs.org> writes:

> Yuan Fu <casouri@gmail.com> writes:
>
>> Mickey Petersen <mickey@masteringemacs.org> writes:
>>
>>> In order to check for node equality, one must use `treesit-node-eq'.
>>>
>>> But I see little reason why two identical nodes in in the same tree aren't 
>>> `equal'?
>>
>> Indeed. I’ll see if I can extend equal to handle tree-sitter nodes.
>>
>
> Nice one. This will allow for membership checks with `member' and
> such-like and it'll greatly cut down on custom code, particularly one
> you start writing tests!
>
>> Yuan

Eli, does this look right to you? In particular, I’m not sure if it’s ok to 
call a lisp function (Ftreesit_node_eq) inside internal_equal, even though it 
never signals. 

Yuan

Attachment: equal.diff
Description: Binary data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]