bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#60127: treesit-end-of-defun: possible bug with clojure grammar


From: Eli Zaretskii
Subject: bug#60127: treesit-end-of-defun: possible bug with clojure grammar
Date: Tue, 17 Jan 2023 14:20:43 +0200

> From: Yuan Fu <casouri@gmail.com>
> Date: Tue, 17 Jan 2023 01:30:22 -0800
> Cc: 60127@debbugs.gnu.org,
>  Danny Freeman <danny@dfreeman.email>,
>  Eli Zaretskii <eliz@gnu.org>
> 
> 
> > I’d rather not use treesit_search_dfs, as it does much more work than
> > the current code. You know what, I can write a custom
> > ts_node_first_child_for_byte and use that in Emacs, I’ve already done
> > that for ts_node_parent anyway.
> 
> I did that. I tested with the Clojure example and it works fine now.
> 
> Eli, we don’t use ts_node_first_child_for_pos for now until tree-sitter
> fix that function, should I removed the boilerplate for it or should I
> leave it as-is? I saw you removed ts_node_parent when I did a similar
> fix.

It should be either removed or #ifdef'ed away, because otherwise GCC
complains in the MS-Windows build about unused macro.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]