[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#60942: 30.0.50; [PATCH] Indices in Eshell variable interpolation don
From: |
Eli Zaretskii |
Subject: |
bug#60942: 30.0.50; [PATCH] Indices in Eshell variable interpolation don't work with async subcommands |
Date: |
Thu, 19 Jan 2023 21:41:34 +0200 |
> Date: Thu, 19 Jan 2023 11:31:24 -0800
> From: Jim Porter <jporterbugs@gmail.com>
> Cc: 60942@debbugs.gnu.org
>
> On 1/18/2023 11:37 PM, Jim Porter wrote:
> > On 1/18/2023 10:49 PM, Eli Zaretskii wrote:
> >> Why do you remove a non-internal function? We cannot possibly do that
> >> if this is going to be installed on the emacs-29 branch. But even if
> >> you are going to install on master, why not leave that function alone?
> >> Some code somewhere could be using it, and we don't usually remove
> >> functions before a period of deprecation.
> >
> > I can keep 'eshell-eval-indices' around and mark it obsolete if you
> > prefer; it wouldn't hurt anything.
>
> Here's a patch that does this. It doesn't try to fix
> 'eshell-eval-indices', since people shouldn't use that anyway. (I also
> renamed the new 'eshell-indices' to 'eshell-prepare-indices' to be clearer.)
Is this for master? If so, okay. Otherwise, you'll need to adjust
the version in the obsolescence declaration.
Thanks.