bug#61014: 29.0.60; flymake-mode stderr warning is confusing when edit the init.el or eary-init.el

[Eli Zaretskii]

> From: Eason Huang <aqua0210@foxmail.com>
> Date: Mon, 23 Jan 2023 10:15:49 +0800
> 
> 
> I found that when editing the init.el or eary-ini.el under
> `user-emacs-directory`, flymake will report the warning as below:
> 
> ```
> Warning (initialization): Your `load-path' seems to contain
> your `.emacs.d' directory: /Users/eason/.emacs.d/
> This is likely to cause problems...
> Consider using a subdirectory instead, e.g.: /Users/eason/.emacs.d/lisp
> ```
> 
> And this is because the variable `elisp-flymake-byte-compile-load-path`
> has a defaut value `("./")`
> 
> so flymake adding the `.emacs.d` to the load-path and then also
> complaining about it, it is confusing to users. May be we can improve
> it.
> 
> Steps to reproduce:
> 
> 1. create a new .emacs.d folder in the HOME directory
> 2. create an empty init.e and eary-init.el file in the .emacs.d folder
> 3. Start Emacs and C-x, C-f open the init.el or early.el
> 4. M-x flymake-mode, add some blank lines in the init.el or early.el
> 5. C-x b, Switch to buffer:  *stderr of elisp-flymake-byte-compile*
> Now you will see the warnings.

João, any comments?  The warning comes from startup.el, but it is
triggered by what Flymake does, AFAICT.

> By the way, the message "Your `load-path' seems to contain
> your `.emacs.d' directory" should use `user-emacs-directory` instead,
> because some user will use `~/.config/emacs/` folder instead of
> `.emacs.d`

I fixed this part.