[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#61104: 29.0.60; typescript-ts-mode does not provide compilation-mode
From: |
Eli Zaretskii |
Subject: |
bug#61104: 29.0.60; typescript-ts-mode does not provide compilation-mode support |
Date: |
Fri, 27 Jan 2023 22:30:02 +0200 |
> Cc: Yuan Fu <casouri@gmail.com>, Theodor Thornhill <theo@thornhill.no>
> Date: Fri, 27 Jan 2023 21:14:30 +0100
> From: Jostein Kjønigsen <jostein@secure.kjonigsen.net>
>
> When compiling a TypeScript project using tsc (or other tooling) from Emacs,
> compilation errors and warnings are not highlighted by compilation-mode.
>
> Consider the following output:
>
> src/resources/document.ts:140:22 - error TS2362: The left-hand side of an
> arithmetic operation must be of
> type 'any', 'number', 'bigint' or an enum type.
>
> 140 return `File-${new Date() * 1}${ext}`;
> ~~~~~~~~~~
>
> This output should cause compilation-mode to highlight the error and provide
> code-navigation.
>
> I know we explicitly added support for this to typescript.el back in the
> days, but I'm not
> sure what the "right" thing to do is now that typescrip-ts-mode is a first
> class Emacs citizen.
>
> Should we add compilation-mode patterns directly to the major-mode, or should
> we provide
> patches to compile.el instead?
Why isn't this part of compilation-error-regexp-alist-alist?