[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#59888: [PATCH] Add 'grep-use-headings'
From: |
Robert Pluim |
Subject: |
bug#59888: [PATCH] Add 'grep-use-headings' |
Date: |
Mon, 27 Feb 2023 17:51:33 +0100 |
>>>>> On Mon, 27 Feb 2023 12:26:08 +0100, Augusto Stoffel <arstoffel@gmail.com>
>>>>> said:
Augusto> On Mon, 27 Feb 2023 at 07:24, Robert Pluim wrote:
>> Itʼs a `defcustom', so by definition itʼs a user option. If youʼre not
>> expecting it to be modified, maybe make it a `defvar'.
Augusto> Oops, I wrote this a couple months back and had forgotten.
Augusto> I don't know if you have an opinion. `grep-regexp-alist' is a
defconst,
Augusto> which seems exaggerated, but `grep-match-regexp' is a defcustom
although
Augusto> nobody should want to change this except to work around bugs.
Augusto> My new variable has a similar "degree of technicality" and I think
that
Augusto> asks for be a defvar.
I think I agree.
Robert
--
- bug#59888: [PATCH] Add 'grep-use-headings', Augusto Stoffel, 2023/02/25
- bug#59888: [PATCH] Add 'grep-use-headings', Juri Linkov, 2023/02/25
- bug#59888: [PATCH] Add 'grep-use-headings', Robert Pluim, 2023/02/26
- bug#59888: [PATCH] Add 'grep-use-headings', Juri Linkov, 2023/02/27
- bug#59888: [PATCH] Add 'grep-use-headings', Augusto Stoffel, 2023/02/27
- bug#59888: [PATCH] Add 'grep-use-headings', Juri Linkov, 2023/02/27
- bug#59888: [PATCH] Add 'grep-use-headings', Juri Linkov, 2023/02/28
- bug#59888: [PATCH] Add 'grep-use-headings', Augusto Stoffel, 2023/02/28