[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#62116: RFE: eglot: support window.showDocument LSP RPC
From: |
Felician Nemeth |
Subject: |
bug#62116: RFE: eglot: support window.showDocument LSP RPC |
Date: |
Sun, 14 May 2023 21:02:02 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
>> Even when takeFous is nil, shouldn't we still at least raise the frame?
>> Otherwise Emacs might not show the document.
>
> I don't understand. Can you show this problem. , I think display-buffer
> ensures the buffer is displayed. It doesn't guarantee that it is
> visible in the context of the windowing system, but that's another
> matter.
I was worried about the case when there are two frames: frame A is in
focus, and frame B is minimized but contains the target buffer. But
you're right. display-buffer does raise frame B and keeps the focus in
frame A.
> I pushed a version with the above adjustments to master, as we're
> converging anyway and it's easier than trading patches.
The pushed version is good, but there is one minor problematic detail.
It returns "success" even before it tries to find-file the requested
URI. So if it cannot open the file, because the user does not have the
required permissions, it is too late to send an error to the server.
- bug#62116: RFE: eglot: support window.showDocument LSP RPC, (continued)
- bug#62116: RFE: eglot: support window.showDocument LSP RPC, Felician Nemeth, 2023/05/08
- bug#62116: RFE: eglot: support window.showDocument LSP RPC, João Távora, 2023/05/08
- bug#62116: RFE: eglot: support window.showDocument LSP RPC, Felician Nemeth, 2023/05/09
- bug#62116: RFE: eglot: support window.showDocument LSP RPC, Alan Donovan, 2023/05/09
- bug#62116: RFE: eglot: support window.showDocument LSP RPC, João Távora, 2023/05/11
- bug#62116: RFE: eglot: support window.showDocument LSP RPC, João Távora, 2023/05/11
- bug#62116: RFE: eglot: support window.showDocument LSP RPC, Alan Donovan, 2023/05/12
- bug#62116: RFE: eglot: support window.showDocument LSP RPC, João Távora, 2023/05/15
- bug#62116: RFE: eglot: support window.showDocument LSP RPC, Felician Nemeth, 2023/05/13
- bug#62116: RFE: eglot: support window.showDocument LSP RPC, João Távora, 2023/05/13
- bug#62116: RFE: eglot: support window.showDocument LSP RPC,
Felician Nemeth <=
- bug#62116: RFE: eglot: support window.showDocument LSP RPC, João Távora, 2023/05/14
- bug#62116: RFE: eglot: support window.showDocument LSP RPC, João Távora, 2023/05/15
- bug#62116: RFE: eglot: support window.showDocument LSP RPC, João Távora, 2023/05/16
- bug#62116: RFE: eglot: support window.showDocument LSP RPC, Alan Donovan, 2023/05/24
- bug#62116: RFE: eglot: support window.showDocument LSP RPC, Dmitry Gutov, 2023/05/24