[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#63469: 29.0.90; project.el doesn't add menu-bar entries
From: |
Eli Zaretskii |
Subject: |
bug#63469: 29.0.90; project.el doesn't add menu-bar entries |
Date: |
Mon, 15 May 2023 21:37:59 +0300 |
> From: Spencer Baugh <sbaugh@janestreet.com>
> Date: Mon, 15 May 2023 14:11:08 -0400
>
> The attached patch resolves this. There's also a slight tweak to the
> text of the menu entry for "Compile" to make it clearer that "compile"
> runs in CWD, where as "project-compile" runs on the current project.
> Otherwise I think it would be slightly confusing.
Thanks.
> (defvar menu-bar-shell-commands-menu
> (let ((menu (make-sparse-keymap "Shell Commands")))
> + (bindings--define-key menu [project-interactive-shell]
> + '(menu-item "Run Shell Interactively In Project" project-shell
> + :help "Run a subshell interactively, in the current
> project"))
What does it mean to "run a shell in the current project"? A shell
doesn't run in a project. Maybe you meant in the project's root
directory?
> + (bindings--define-key menu [project-compile]
> + '(menu-item "Compile Project..." project-compile
> + :help "Invoke compiler or Make for current project, view
> compilation errors"))
This tool-tip text is too long. Maybe drop the "compilation" part.
> + '(menu-item "Compile Current Directory..." compile
> + :help "Invoke compiler or Make in current directory, view
> compilation errors"))
What is a "current directory" when you are talking about Emacs?
> + (list 'select-buffer-in-project
> + 'menu-item
> + "Select Buffer In Project..."
> + 'project-switch-to-buffer
> + :help "Prompt for a buffer name in the current project, and
> select that buffer in the current window")
This tool-tip text is _way_ too long.
- bug#63469: 29.0.90; project.el doesn't add menu-bar entries, Spencer Baugh, 2023/05/12
- bug#63469: 29.0.90; project.el doesn't add menu-bar entries, Eli Zaretskii, 2023/05/12
- bug#63469: 29.0.90; project.el doesn't add menu-bar entries, Juri Linkov, 2023/05/15
- bug#63469: 29.0.90; project.el doesn't add menu-bar entries, Spencer Baugh, 2023/05/15
- bug#63469: 29.0.90; project.el doesn't add menu-bar entries,
Eli Zaretskii <=
- bug#63469: 29.0.90; project.el doesn't add menu-bar entries, Spencer Baugh, 2023/05/15
- bug#63469: 29.0.90; project.el doesn't add menu-bar entries, Eli Zaretskii, 2023/05/16
- bug#63469: 29.0.90; project.el doesn't add menu-bar entries, Spencer Baugh, 2023/05/16
- bug#63469: 29.0.90; project.el doesn't add menu-bar entries, Eli Zaretskii, 2023/05/17
- bug#63469: 29.0.90; project.el doesn't add menu-bar entries, Spencer Baugh, 2023/05/17
- bug#63469: 29.0.90; project.el doesn't add menu-bar entries, Dmitry Gutov, 2023/05/18
- bug#63469: 29.0.90; project.el doesn't add menu-bar entries, Eli Zaretskii, 2023/05/18
- bug#63469: 29.0.90; project.el doesn't add menu-bar entries, Dmitry Gutov, 2023/05/18
- bug#63469: 29.0.90; project.el doesn't add menu-bar entries, Eli Zaretskii, 2023/05/18
- bug#63469: 29.0.90; project.el doesn't add menu-bar entries, Spencer Baugh, 2023/05/18