bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#61413: [PATCH] Make warnings show a "warning" emoji instead of a sto


From: Kévin Le Gouguec
Subject: bug#61413: [PATCH] Make warnings show a "warning" emoji instead of a stop-sign
Date: Thu, 20 Feb 2025 22:50:33 +0100
User-agent: Gnus/5.13 (Gnus v5.13)

Mauro Aranda <maurooaranda@gmail.com> writes:

>>> I think we'd like something similar for buttonize-region, so I wonder if
>>> it's not better to do the change inside button--properties, though.
>>
>> ACK to improve buttonize-region too.  button--properties does not have
>> access to the information needed to get the fallback help-echo tho
>> (STRING for buttonize, START END for buttonize-region), are you thinking
>> of passing that fallback as a new argument, or have I missed something?
>
> I was thinking in not overwriting the help-echo property if the
> help-echo argument is nil.

💡 Gotcha.  Much cleaner than the original patch - that
(get-text-property 0 …) was not very elegant.

> Currently, button--properties forces a value for the help-echo property.
> So it would be like: If it's nil,  don't add the help-echo property to
> the property list at all, leaving a previous help-echo property
> untouched.

How does the attached look?

Attachment: 0001-Prevent-button.el-from-clearing-help-echo-strings.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]