[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: getaddrinfo.h: HAVE_SYS_TYPES_H needed?
From: |
Simon Josefsson |
Subject: |
Re: getaddrinfo.h: HAVE_SYS_TYPES_H needed? |
Date: |
Wed, 05 Oct 2005 09:50:32 +0200 |
User-agent: |
Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux) |
Jim Meyering <address@hidden> writes:
> Hi Simon,
>
> I noticed that getaddrinfo.h guards the inclusion of <sys/types.h>
> with an #ifdef HAVE_SYS_TYPES_H.
> Do you know of a system that lacks <sys/types.h>?
Hi Jim! No, I don't.
> I don't see any other uses of HAVE_SYS_TYPES_H in gnulib.
I removed the check.
> How about HAVE_SYS_SOCKET_H?
> At least poll.c uses <sys/socket.h> without the conditional.
>
> It's best to avoid the conditionals, when possible.
Mingw32 doesn't have sys/socket.h, but gnulib doesn't support it
anyway, so I removed the check. The proper fix on mingw32 would be to
supply, in a gnulib module, some working sys/socket.h files.
What about netdb.h then? Is there any system that lack it?
I'm leaving the tests in getaddrinfo.m4 for a while, so that more
debug information end up in config.log.
Thanks,
Simon